Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: add editable to dist type #764

Merged
merged 2 commits into from
Apr 4, 2024
Merged

build: add editable to dist type #764

merged 2 commits into from
Apr 4, 2024

Conversation

layday
Copy link
Member

@layday layday commented Mar 29, 2024

Closes #763.

@dimbleby
Copy link

thanks! an alias for the three-way literal would be a convenience for callers, though of course we can write our own

@layday
Copy link
Member Author

layday commented Mar 31, 2024

We could, though I'm not sure what would be a good name for it. I could also see us adding editable to the Distribution set and creating a secondary, internal literal for the CLI. I'm inclined to leave it as is for now.

@dimbleby
Copy link

dimbleby commented Mar 31, 2024

I'm not sure what would be a good name for it.

Haha, well I guess callers will just have to answer that ourselves.

Honestly I think that declining to put a name on this part of the interface is a minor failure, but it's one that users can paper over.

@layday layday merged commit 9eede71 into pypa:main Apr 4, 2024
57 checks passed
@layday layday deleted the fix-dist-type branch April 4, 2024 09:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

types in release 1.2.1 exclude "editable"
3 participants