Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs: Fix forward reference in docs check #805

Closed
wants to merge 1 commit into from
Closed

docs: Fix forward reference in docs check #805

wants to merge 1 commit into from

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Aug 28, 2024 •
edited
Loading

@edgarrmondragon edgarrmondragon marked this pull request as draft August 28, 2024 16:05
@henryiii
Copy link
Contributor

Looks like setuptools 74 broke our tests. I'm fixing other fallout from 74 in scikit-build (classic) currently. :)

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 29, 2024 00:02
@edgarrmondragon edgarrmondragon force-pushed the fix-docs-check branch 2 times, most recently from 56d3cc6 to ff62f60 Compare September 4, 2024 05:23
@henryiii
Copy link
Contributor

henryiii commented Sep 4, 2024

Going to fix in #804 since the docs don't run if they aren't changed.

@edgarrmondragon
Copy link
Contributor Author

Going to fix in #804 since the docs don't run if they aren't changed.

Gotcha 👍, I'll close this then.

@edgarrmondragon edgarrmondragon deleted the fix-docs-check branch September 4, 2024 20:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@gaborbernat gaborbernat Awaiting requested review from gaborbernat gaborbernat is a code owner

@layday layday Awaiting requested review from layday layday is a code owner

@henryiii henryiii Awaiting requested review from henryiii henryiii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @henryiii