Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

💅 Bundle attestation existence check together #315

Merged

Conversation

webknjaz
Copy link
Member

This patch moves said check out of the signing loop and performs the check early in the process. It is then able to report multiple problems in a single error.

This patch moves said check out of the signing loop and performs the
check early in the process. It is then able to report multiple
problems in a single error.
@webknjaz webknjaz added the enhancement New feature or request label Dec 10, 2024
@webknjaz webknjaz requested a review from woodruffw December 10, 2024 00:54
@webknjaz
Copy link
Member Author

@woodruffw does this seem reasonable? We can then make it a conditional warning in the same place in a follow-up, and it wouldn't spam people with many warnings.

@woodruffw
Copy link
Member

@woodruffw does this seem reasonable? We can then make it a conditional warning in the same place in a follow-up, and it wouldn't spam people with many warnings.

Yeah, seems reasonable to me 🙂

@webknjaz webknjaz merged commit 916e576 into pypa:unstable/v1 Dec 10, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants