Restore pyproject.toml handling to its version 19.0.3 state #6449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
skip news
|
(I had to add the trivial label since changing an existing news entry doesn't seem to satisfy the bot.) |
|
Shall we release this @cjerdonek? |
openstack-gerrit
pushed a commit
to openstack/project-config
that referenced
this pull request
May 6, 2019
As pointed out by ajaeger; the wheel build jobs are failing with Error installing 'pip from git+https://github.com/ianw/pip.git@path-and-hash#egg=pip': editable mode is not supported for pyproject.toml-style projects. This appears to be an issue with pip 19.0 which would be installed on the build hosts, interacting with projects that have a pyproject.toml file. The problem only seems to be related to installing in editable mode, which we don't really need here on this ephemeral host. So just switch to a regular install, with upgrade/reinstall to be sure. [1] pypa/pip#6449 Change-Id: I006500a2c98f512176fbac4ab426a8719243fc70
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
May 6, 2019
* Update project-config from branch 'master'
- wheel-build: Work around pip 19.0 errors
As pointed out by ajaeger; the wheel build jobs are failing with
Error installing 'pip from
git+https://github.com/ianw/pip.git@path-and-hash#egg=pip': editable
mode is not supported for pyproject.toml-style projects.
This appears to be an issue with pip 19.0 which would be installed on
the build hosts, interacting with projects that have a pyproject.toml
file.
The problem only seems to be related to installing in editable mode,
which we don't really need here on this ephemeral host. So just
switch to a regular install, with upgrade/reinstall to be sure.
[1] pypa/pip#6449
Change-Id: I006500a2c98f512176fbac4ab426a8719243fc70
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a candidate PR to restore pip's
pyproject.tomlhandling to how it was with 19.0.3 in response to community feedback on the tracker and elsewhere -- namely so that--no-use-pep517doesn't have to be added to use editable mode whenpyproject.tomlis present. It reverts all commits that touchedpyproject.py.As a side effect, this also undoes some refactoring that was done to make the
pyproject.pycode more testable, and it removes test cases that provided more test coverage. But those things can always be added back later. Merging this will also mean that issue #6314 will need to be addressed in a different way.