Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Message for Pipfile.lock packages vulnerabilities check #5628

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

ryan-rozario
Copy link
Contributor

@ryan-rozario ryan-rozario commented Mar 10, 2023

The issue

pipenv check still prints "Checking installed packages for vulnerabilities...", regardless of it's using the installed environment with --use-installed or if it's using the dependencies from Pipfile.lock. If using default behavior, this should read something like "Checking Pipfile.lock packages for vulnerabilities..."

Fix #5600

The fix

Show a different message if --use-installed is specified in pipenv check

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@ryan-rozario ryan-rozario changed the title Message for Pipfile.lock vulnerabilities check Message for Pipfile.lock packages vulnerabilities check Mar 10, 2023
@matteius matteius merged commit ad5a8ac into pypa:main Mar 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipenv check looks at installed packages, not Pipfile.lock
2 participants