Some improvemets in requirementslib for clarity #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
reviewed
Oct 21, 2024
|
@vshulcz can you please add a news file? |
|
I'd be fine merging this as-is considering the scope of the other changes and the comprehensive news fragment I added there. Just to be able to cut a release sooner 😅 |
vshulcz
added a commit
to vshulcz/pipenv
that referenced
this pull request
Oct 22, 2024
matteius
added
Status: Accepted ✔️
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
This PR addresses a couple of areas in the code where improvements in argument handling and path management were needed.
This PR does not fix a specific GitHub issue but addresses overall code quality.
The fix
Removed an extra space after -i, added some mini docstrings, improved the path handling logic.
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.