Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

pep425tags: turn warning into a debug log entry #1332

Merged
merged 1 commit into from
Apr 20, 2018
Merged

pep425tags: turn warning into a debug log entry #1332

merged 1 commit into from
Apr 20, 2018

Conversation

tkhyn
Copy link
Contributor

@tkhyn tkhyn commented Apr 18, 2018

@pganssle pganssle requested a review from benoit-pierre April 20, 2018 14:03
@pganssle pganssle merged commit af4e065 into pypa:master Apr 20, 2018
@pganssle
Copy link
Member

Should we change the warn parameter in any way? It doesn't actually raise a warning anymore, nor does it use log.warn.

@benoit-pierre
Copy link
Member

I'd rather keep the changes to a minimum so it's easier to merge-in updates from pip/wheel.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benoit-pierre benoit-pierre benoit-pierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Py_DEBUG and WITH_PYMALLOC warnings [Windows]
3 participants
@tkhyn @pganssle @benoit-pierre