Support for scripts with unicode content #1389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
reviewed
Jun 29, 2018
changelog.d/1366.change.rst
Outdated
| @@ -1 +1,2 @@ | |||
| In package_index, fixed handling of encoded entities in URLs. | |||
| Scripts which have unicode content are now sopported | |||
There was a problem hiding this comment.
This should be in its own changelog file, changelog.d/1389.change.rst
pganssle
reviewed
Jun 29, 2018
setuptools/command/easy_install.py
Outdated
| @@ -108,7 +108,7 @@ def isascii(s): | |||
| else: | |||
|
|
|||
| def _to_ascii(s): | |||
| return s.encode('ascii') | |||
| return s.encode('utf8') | |||
There was a problem hiding this comment.
Hm... Looking at what this does I think I agree with this change (though I don't know nearly enough about unicode issues to fully judge it), but maybe we should also change _to_ascii to _to_bytes?
Also, this change definitely needs tests.
There was a problem hiding this comment.
You mean having only the _to_bytes() function?
BTW, tests added
There was a problem hiding this comment.
Well just _to_ascii sounds like it turns something to an encoded ASCII string, but this is actually returning a utf-8-encoded byte string, so it should probably be called _to_bytes() instead of _to_ascii().
|
@pganssle fixed |
2 tasks
pganssle
force-pushed
the
scripts_ascii
branch
from
e239095 to
d94437c
Compare
pganssle
pushed a commit
to expobrain/setuptools
that referenced
this pull request
Aug 17, 2018
pganssle
approved these changes
Aug 17, 2018
pganssle
force-pushed
the
scripts_ascii
branch
from
d94437c to
c43d0f6
Compare
This also renames the _to_ascii function to better reflect its purpose.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Makes the
_to_ascii()function able to handle script's contents in unicode format.Closes #761
Pull Request Checklist