Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sync with distutils@30b7331 #4576

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Sync with distutils@30b7331 #4576

merged 7 commits into from
Aug 19, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Aug 19, 2024

  • Let _show_help() use commands instead of self.commands
  • Enforce flake8-bugbear (B) and isort (I) ruff rules
  • Add test capturing missed expectation.
  • Ensure a missing target is still indicated as 'sources are newer' even when there are no sources.

Summary of changes

Style changes plus pypa/distutils#276 and pypa/distutils#284.

Pull Request Checklist

DimitriPapadopoulos and others added 7 commits August 3, 2024 20:46
Depending on the context, _show_help() is called with a different
commands argument. I believe the intent was to adapt the help message
to the context. However, it would operate on self.commands instead
of the commands argument, which would break this purpose.
…help

Let _show_help() use commands instead of self.commands
Enforce flake8-bugbear (`B`) and isort (`I`) ruff rules
@jaraco jaraco force-pushed the bugfix/distutils-284 branch from 9f20cd5 to ad611bc Compare August 19, 2024 20:15
@jaraco jaraco merged commit 2ad8c10 into main Aug 19, 2024
32 checks passed
@jaraco jaraco deleted the bugfix/distutils-284 branch August 19, 2024 20:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants