Skip to content

Refactor OIDC mint token endpoint (cont. #14063) #15148

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 10, 2024
Merged

Refactor OIDC mint token endpoint (cont. #14063) #15148

merged 12 commits into from
Jan 10, 2024

Conversation

woodruffw
Copy link
Member

See #14063.

For merge: please preserve the original author, since this is just me getting things deconflicted/resolved.

th3coop and others added 6 commits November 22, 2023 13:05
@th3coop
Refactor OIDC mint token endpoint
05b3d06 
Make it easier to mint tokens with additional publishers
@th3coop
Move default JWT validation to general OIDC handler function
40b1708
@th3coop
publisher_name to method. Add more factories. Publisher agnostic toke…
e750531 
…n handler tests
@woodruffw
Merge branch 'main' into OIDC-Publisher-refactor-mint-token-handling
fa153ec 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
oidc/views: typo: JsonRespone -> JsonResponse
2c0b230 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lintage, begin making OIDC endpoint generic
437a490 
Signed-off-by: William Woodruff <william@trailofbits.com>
@th3coop th3coop mentioned this pull request Jan 5, 2024
Closed
@woodruffw
tests, warehouse: generic OIDC minting endpoint
6de12b0 
Needs coverage, but the idea is done.

Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
woodruffw commented Jan 5, 2024
View reviewed changes
@woodruffw
tests: complete coverage
29cf6a9 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
tests, warehouse: eliminate impossible states
e11aedb 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review January 5, 2024 22:36
@woodruffw woodruffw requested a review from a team as a code owner January 5, 2024 22:36
@woodruffw woodruffw self-assigned this Jan 5, 2024
@woodruffw woodruffw requested a review from di January 5, 2024 22:36
woodruffw
woodruffw commented Jan 5, 2024
View reviewed changes
woodruffw
woodruffw commented Jan 5, 2024
View reviewed changes
woodruffw
woodruffw commented Jan 5, 2024
View reviewed changes
@di di mentioned this pull request Jan 6, 2024
Merged
2 tasks
@th3coop th3coop mentioned this pull request Jan 6, 2024
Closed
di
di reviewed Jan 8, 2024
View reviewed changes
@woodruffw
tests, warehouse: feedback
8c6933d 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Merge remote-tracking branch 'upstream/main' into OIDC-Publisher-refa…
2b76ab2 
…ctor-mint-token-handling
@woodruffw woodruffw requested a review from miketheman January 8, 2024 17:58
@woodruffw
error specialization
c6a8d96 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

I believe this is good to go -- @di are you thinking this should get merged first, or after #15144?

@di
Copy link
Member

di commented Jan 10, 2024

I think we can merge this first!

@di di merged commit 30480f3 into pypi:main Jan 10, 2024
@di di deleted the OIDC-Publisher-refactor-mint-token-handling branch January 10, 2024 16:04
This was referenced Jan 10, 2024
Merged
Merged
Closed
Merged
@di di mentioned this pull request Jan 11, 2024
Draft
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@th3coop th3coop th3coop left review comments

@di di di approved these changes

@miketheman miketheman Awaiting requested review from miketheman

Assignees

@woodruffw woodruffw

Labels
trusted-publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woodruffw @di @th3coop