-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
PERF: Optimize point transformations #1204
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1204 +/- ##
=======================================
Coverage 96.28% 96.29%
=======================================
Files 20 20
Lines 1804 1808 +4
=======================================
+ Hits 1737 1741 +4
Misses 67 67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This works great for me.
0a04665
to
62ec762
Compare
519da77
to
03ee8f5
Compare
03ee8f5
to
045714a
Compare
With #1208
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I get similar timings to you, and not a major slowdown for trying this before going down the other path. So, I do like this better than adding a new method, and theoretically downstream users should be able to get immediate benefits without needing to change the call sites.
045714a
to
4e6d05f
Compare
I agree |
d0a7f4e
to
5fda90a
Compare
5fda90a
to
b9225a3
Compare
b9225a3
to
c9126d3
Compare
Related: #1202
Version in #1203: