Enhance remove_false_nodes Function: Retain Line Attributes and Expose aggfunc Parameter. #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e running the examples.
Key Changes: Added retain_attributes and aggfunc parameters to the function signature. Created a list new_attrs to store the aggregated attributes if retain_attributes is True. Aggregated attributes using aggfunc and added them to new_attrs during the loop that processes connected components. Combined final_df with the new attributes if retain_attributes is True.
|
Hi, sorry. This function has been moved to https://github.com/uscuni/neatnet where the aggregation has been implemented already. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #447
Key Changes:
-Added retain_attributes and aggfunc parameters to the function signature.
-Created a list new_attrs to store the aggregated attributes if retain_attributes is True.
-Aggregated attributes using aggfunc and added them to new_attrs during the loop that processes connected components.
-Combined final_df with the new attributes if retain_attributes is True.