populate symbols for samtools and bcftools. #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks! |
This was referenced Oct 22, 2024
jmarshall
added a commit
to jmarshall/pysam
that referenced
this pull request
Oct 22, 2024
Simplify the code by just writing these out directly, and hence letting type checkers just infer the obvious type. Make PysamDispatch(parsers=...) an optional parameter, as nothing now uses these parsers anyway. Remove "import_", which was added as an alias of "fqimport" in PR pysam-developers#1143 without announcement or documentation and seemingly accidentally. The redundant "import_" appeared in v0.21.0, but "fqimport" has been present since v0.17.0. Define __all__ in pysam/bcftools.py for good measure. Import all of pysam.utils to avoid pysam.{sam,bcf}tools.PysamDispatcher namespace pollution -- pysam.utils will be imported anyway.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve mypy symbols