Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement VariantRecord#calc_number #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

multimeric
Copy link

See #669

  • Expose bcf_get_value_count as VariantRecord#calc_number
  • Add tests for this
  • Some extra docstrings

@multimeric
Copy link
Author

Some questions about my implementation:

  • My editor auto-formatted the code, should I undo that?
  • I make users specify INFO or FMT as a string to determine the type of field. Should I expose an enum/constant for these values instead? If strings, should I use FORMAT instead of FMT? Do we have a precedent?

@bioinformed
Copy link
Member

Re editor reformatting: Yes-- you'll need to undo all of that for this MR to be considered.
Re API for FMT vs. INFO: I left some suggestions in #669.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants