Skip to content

Avoid using setup_requires parameter in setup.py #9

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
approxit opened this issue Jul 30, 2020 · 3 comments · Fixed by #10
Closed

Avoid using setup_requires parameter in setup.py #9

approxit opened this issue Jul 30, 2020 · 3 comments · Fixed by #10

Comments

@approxit
Copy link

Howdy!

I stumbled upon problem with setup_requires and pip/poetry while using corporate PYPI mirror. As this package is used by pytest 6.0 (released 2 days ago) it can break things for many people.

Current workaround is to install setuptools-scm manually via pip, before poetry, but it still requires time to debug and fix.

More references for this problem: pytest-dev/pytest-xdist#136 pypa/setuptools#209
@metaperl
Copy link

I second this for the same reason: our corporate PyPI mirror is attempting to install setuptools-scm via PyPI instead of the internal PyPi mirror for some reason.

Not to mention that setup_requires is discouraged in PEP 518 and the setuptools docs.

RonnyPfannschmidt added a commit that referenced this issue Jul 31, 2020
@RonnyPfannschmidt
fix #9 no longer use setup_requires
848ea5a
@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Jul 31, 2020
Merged
RonnyPfannschmidt added a commit that referenced this issue Jul 31, 2020
@RonnyPfannschmidt
Merge pull request #10 from RonnyPfannschmidt/fix-9-use-pyproject
4f84396 
fix #9 no longer use setup_requires
@RonnyPfannschmidt
Copy link
Member

released in https://pypi.org/project/iniconfig/1.0.1/

@baurst
Copy link

baurst commented Jul 31, 2020 •
edited
Loading

Thank you very much for the quick fix! 👍

@florimondmanca florimondmanca mentioned this issue Oct 14, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #9 no longer use setup_requires pytest-dev/iniconfig
4 participants
@metaperl @RonnyPfannschmidt @approxit @baurst