Skip to content

Fix version autodetection from git tags #15

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fix version autodetection from git tags #15

merged 1 commit into from
Oct 14, 2020

Conversation

florimondmanca
Copy link
Contributor

Fixes #14 (provided a new release of this package to PyPI)

#10 dropped the setup_requires option by moving build requirements to pyproject.toml. Sounds fair enough, but #10 also dropped use_scm_version, while the versioning strategy hasn't changed (at least, there's no explicit version option passed to setup()). So it looks like it was an oversight, and this PR adds the option back.

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@RonnyPfannschmidt RonnyPfannschmidt merged commit 17af01f into pytest-dev:master Oct 14, 2020
@florimondmanca florimondmanca deleted the patch-1 branch October 14, 2020 10:14
@florimondmanca
Copy link
Contributor Author

Thanks @RonnyPfannschmidt :-)

@Czaki
Copy link

Czaki commented Oct 14, 2020

When next release?

@RonnyPfannschmidt
Copy link
Member

after changelog

@RonnyPfannschmidt
Copy link
Member

should be out after the pipeline finishes

@florimondmanca
Copy link
Contributor Author

florimondmanca commented Oct 14, 2020

@RonnyPfannschmidt Can confirm the new 1.1.1 release got our CI pipelines succeeding again! Thanks a ton for jumping in so promptly. :-)

P.S.: @Czaki Don't think that's how you meant it to come across, but I think at least a quick "thanks" to Ronny for going out of his way and cutting a new release to allow you and other folks' to fix up builds would have been a nice gesture. To avoid spreading a culture of entitlement in open source, small things like these matter. 👍

@Czaki
Copy link

Czaki commented Oct 14, 2020

Sorry for my lack of culture. I was beetwen two meetings. Thanks for fast reaction and bugfix.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging version issue with latest release 1.1.0
3 participants