svnwc: fix regular expression vulnerable to DoS in blame functionality #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subpattern `\d+\s*\S+` is ambiguous which makes the pattern subject to catastrophic backtracing given a string like `"1" * 5000`. SVN blame output seems to always have at least one space between the revision number and the user name, so the ambiguity can be fixed by changing the `*` to `+`. Fixes pytest-dev#256.
|
Going to assume no one has an issue with this and merge. |
cclauss
added a commit
to cclauss/py
that referenced
this pull request
Sep 20, 2020
earthgecko
added a commit
to earthgecko/skyline
that referenced
this pull request
Dec 12, 2020
IssueID #3694: #3874: SNYK-PYTHON-PY-1049546 Dependency vulnerability - py - CVE-2020-29651 #378 - Update py to 1.10.0 which resolves CVE-2020-29651 by implementing pytest-dev/py#257 which fixes pytest-dev/py#256 Modified: dev-requirements.txt requirements.txt
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256.
The subpattern
\d+\s*\S+is ambiguous which makes the pattern subjectto catastrophic backtracing given a string like
"1" * 5000.SVN blame output seems to always have at least one space between the
revision number and the user name, so the ambiguity can be fixed by
changing the
*to+.