Clarify event_loop fixture deprecation #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message new refers to the "loop_scope" keyword argument, rather than "scope".
seifertm
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
=======================================
Coverage 91.10% 91.10%
=======================================
Files 2 2
Lines 562 562
Branches 74 74
=======================================
Hits 512 512
Misses 30 30
Partials 20 20 ☔ View full report in Codecov by Sentry. |
asvetlov
approved these changes
Dec 31, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the docs to reflect the fact that the event_loop fixture is deprecated.
Additionally, it fixes the warning message that is emitted when users redefine the fixture and fixes a broken link in the docs.
Closes #964