Skip to content

Retain input ordering in loadscope #1098

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Toad2186
Copy link

@Toad2186 Toad2186 commented Jun 12, 2024

  • Optionally retain input ordering in loadscope for tests where relative ordering matters. i.e. guarantee that, given [input_1, input_2], input_2 never runs before input_1. On any given worker, either input_1 has ran before input_2, or input_1 has never and will never run on this worker.

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Make sure to include reasonable tests for your change if necessary

  • We use towncrier for changelog management, so please add a news file into the changelog folder following these guidelines:

    • Name it $issue_id.$type for example 588.bugfix;

    • If you don't have an issue_id change it to the PR id after creating it

    • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

    • Make sure to use full sentences with correct case and punctuation, for example:

      Fix issue with non-ascii contents in doctest text files.
      

@Toad2186 Toad2186 force-pushed the toan/loadscope-retain-ordering branch 2 times, most recently from 86476d4 to 4d1892a Compare June 12, 2024 23:51
* Optionally retain input ordering in loadscope for tests where relative
  ordering matters. i.e. guarantee that, given [input_1, input_2],
  input_2 never runs before input_1. On any given worker, either input_
  has ran before input_2, or input_1 has never and will never run on
  this worker.
@Toad2186 Toad2186 force-pushed the toan/loadscope-retain-ordering branch from 4d1892a to ef17eac Compare June 12, 2024 23:51
@zacharyburnett
Copy link

this would be very helpful for slow tests in small modules

@@ -0,0 +1 @@
With `--no-loadscope-reorder`, retain input ordering in loadscope for tests where relative ordering matters. i.e. guarantee that, given [input_1, input_2],input_2 never runs before input_1. On any given worker, either input_1 has ran before input_2, or input_1 has never and will never run on this worker. This only applies when using `loadscope`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is going into CHANGELOG.rst, these backticks should be double, I think

Suggested change
With `--no-loadscope-reorder`, retain input ordering in loadscope for tests where relative ordering matters. i.e. guarantee that, given [input_1, input_2],input_2 never runs before input_1. On any given worker, either input_1 has ran before input_2, or input_1 has never and will never run on this worker. This only applies when using `loadscope`.
With ``--no-loadscope-reorder``, retain input ordering in loadscope for tests where relative ordering matters. i.e. guarantee that, given [input_1, input_2],input_2 never runs before input_1. On any given worker, either input_1 has ran before input_2, or input_1 has never and will never run on this worker. This only applies when using ``loadscope``.

@Toad2186
Copy link
Author

If this ever get traction from upstream, I'll fix it ;).

@darwintree
Copy link

Seems this branch is out-of-date with the base branch. Really looking for to have this merged in main branch

@Toad2186
Copy link
Author

Seems this branch is out-of-date with the base branch.

Same response as above. I can fix it if it gets traction. Otherwise there's no point because it'll just become stale again.

@albertino87
Copy link

what is needed for this to be merged?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants