Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix hang caused by steal command with empty test queue #885

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Fix hang caused by steal command with empty test queue #885

merged 1 commit into from
Mar 10, 2023

Conversation

amezin
Copy link
Collaborator

@amezin amezin commented Mar 9, 2023

Fixes #884

nicoddemus
nicoddemus approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor suggestions, otherwise LGTM. 👍

Thanks for tackling this so quickly.

After this gets merged, feel free to prepare a new release.

changelog/884.bugfix Outdated Show resolved Hide resolved
src/xdist/remote.py Show resolved Hide resolved
@amezin amezin requested a review from nicoddemus March 9, 2023 14:48
@reaperhulk
Copy link

Verified this stops the hanging we were seeing in the pyca/cryptography test suite. Thanks @amezin!

@amezin amezin merged commit b6c195a into pytest-dev:master Mar 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--dist=worksteal + high core counts leads to hangs
3 participants
@amezin @reaperhulk @nicoddemus