Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[6.2.x] Missing backports to fix CI #9042

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Aug 26, 2021

@nicoddemus
Copy link
Member Author

nicoddemus commented Aug 26, 2021

@RonnyPfannschmidt do you recall something that we changed (somewhat) recently regarding setuptools-scm which we might not have ported to 6.2.x?

  File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\pytest\__init__.py", line 5, in <module>
    from _pytest.assertion import register_assert_rewrite
  File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\_pytest\assertion\__init__.py", line 9, in <module>
    from _pytest.assertion import rewrite
  File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\_pytest\assertion\rewrite.py", line 33, in <module>
    from _pytest._version import version
ModuleNotFoundError: No module named '_pytest._version'

@RonnyPfannschmidt
Copy link
Member

@nicoddemus it's a bug in the new release of setuptools_scm, will start debugging now

@nicoddemus
Copy link
Member Author

Thanks!

@RonnyPfannschmidt
Copy link
Member

@nicoddemus for now i yanked the release, there seems to be an issue wrt setuptools version interaction that trips things over

@nicoddemus nicoddemus changed the title [6.2.x] Merge pull request #9040 from nicoddemus/bump-pluggy [6.2.x] Missing backports to fix CI Aug 27, 2021
@nicoddemus
Copy link
Member Author

nicoddemus commented Aug 27, 2021

@RonnyPfannschmidt seems we are getting a new error with the latest setuptools-scm 6.1.1:

      File "C:\Users\RUNNER~1\AppData\Local\Temp\pip-build-env-6mgyilzk\overlay\Lib\site-packages\setuptools_scm\integration.py", line 52, in infer_version
        config = Configuration.from_file(dist_name=dist_name)
      File "C:\Users\RUNNER~1\AppData\Local\Temp\pip-build-env-6mgyilzk\overlay\Lib\site-packages\setuptools_scm\config.py", line 187, in from_file
        defn = _load_toml(data)
      File "C:\Users\RUNNER~1\AppData\Local\Temp\pip-build-env-6mgyilzk\overlay\Lib\site-packages\setuptools_scm\config.py", line 59, in _lazy_tomli_load
        from tomli import loads
    ModuleNotFoundError: No module named 'tomli'

https://github.com/pytest-dev/pytest/runs/3442315198

Do you know what we need to adjust here?

@RonnyPfannschmidt
Copy link
Member

It's another regression missed due to the ci/testing not having enough isolation for setuptools_scm

@nicoddemus
Copy link
Member Author

It's another regression missed due to the ci/testing not having enough isolation for setuptools_scm

Oh bummer. 😕

I see you yanked 6.1.1, I have triggered the jobs again. Thanks!

@nicoddemus nicoddemus merged commit d74baf4 into pytest-dev:6.2.x Aug 27, 2021
@nicoddemus nicoddemus deleted the backport-9040 branch August 27, 2021 12:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants