Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow parsing .po files that have an extant but empty Language header #1101

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

akx
Copy link
Member

@akx akx commented Jul 17, 2024

Fixes #1087.

Some tools apparently generate somewhat strange Language MIME headers, so we'll treat them like the Language was unset.

Trying catalog.locale = "" by hand will still happily crash; this only affects MIME parsing.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (2f87363) to head (3abacbc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1101   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files          26       26           
  Lines        4470     4470           
=======================================
  Hits         4072     4072           
  Misses        398      398           
Flag Coverage Δ
macos-12-3.10 89.91% <100.00%> (ø)
macos-12-3.11 89.91% <100.00%> (ø)
macos-12-3.12 90.20% <100.00%> (ø)
macos-12-3.8 89.83% <100.00%> (ø)
macos-12-3.9 89.90% <100.00%> (ø)
macos-12-pypy3.10 89.91% <100.00%> (ø)
ubuntu-22.04-3.10 89.93% <100.00%> (ø)
ubuntu-22.04-3.11 89.93% <100.00%> (ø)
ubuntu-22.04-3.12 90.22% <100.00%> (ø)
ubuntu-22.04-3.8 89.85% <100.00%> (ø)
ubuntu-22.04-3.9 89.92% <100.00%> (ø)
ubuntu-22.04-pypy3.10 89.93% <100.00%> (ø)
windows-2022-3.10 90.27% <100.00%> (ø)
windows-2022-3.11 90.27% <100.00%> (ø)
windows-2022-3.12 90.57% <100.00%> (ø)
windows-2022-3.8 90.20% <100.00%> (ø)
windows-2022-3.9 90.27% <100.00%> (ø)
windows-2022-pypy3.10 90.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akx akx merged commit 2ebc47e into master Jul 23, 2024
23 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Babel can't parse PO files created by Django (blank Language in header)
2 participants