Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix formatting for "Empty locale identifier" exception added in #1164 #1184

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

akx
Copy link
Member

@akx akx commented Feb 3, 2025

Refs #1183.

Before

$ env LANG= LC_TIME= uvx --from=babel==2.17.0 --python=3.13 python ~/Desktop/reproducer.py
[...]
TypeError: ("Empty locale identifier value: None\n\nIf you didn't explicitly pass an empty value to a Babel function, this could be caused by there being no suitable locale environment variables for the API you tried to use.",)

After

$ env LANG= LC_TIME= python ~/Desktop/reproducer.py
[...]
TypeError: Empty locale identifier value: None

If you didn't explicitly pass an empty value to a Babel function, this could be caused by there being no suitable locale environment variables for the API you tried to use.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (b50a1d2) to head (14d625b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1184   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          27       27           
  Lines        4689     4689           
=======================================
  Hits         4299     4299           
  Misses        390      390           
Flag Coverage Δ
macos-14-3.10 90.72% <ø> (ø)
macos-14-3.11 90.65% <ø> (ø)
macos-14-3.12 90.87% <ø> (ø)
macos-14-3.13 90.87% <ø> (ø)
macos-14-3.8 90.58% <ø> (ø)
macos-14-3.9 90.65% <ø> (ø)
macos-14-pypy3.10 90.72% <ø> (ø)
ubuntu-24.04-3.10 90.74% <ø> (ø)
ubuntu-24.04-3.11 90.68% <ø> (ø)
ubuntu-24.04-3.12 90.89% <ø> (ø)
ubuntu-24.04-3.13 90.89% <ø> (ø)
ubuntu-24.04-3.8 90.61% <ø> (ø)
ubuntu-24.04-3.9 90.67% <ø> (ø)
ubuntu-24.04-pypy3.10 90.74% <ø> (ø)
windows-2022-3.10 90.73% <ø> (ø)
windows-2022-3.11 90.67% <ø> (ø)
windows-2022-3.12 90.88% <ø> (ø)
windows-2022-3.13 90.88% <ø> (ø)
windows-2022-3.8 90.70% <ø> (ø)
windows-2022-3.9 90.66% <ø> (ø)
windows-2022-pypy3.10 90.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx merged commit 27e7303 into master Feb 3, 2025
26 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant