Fix crash when uname -rs output is empty (#304)

> closes #264
python-distro · Sep 26, 2021 · d3e9194 · d3e9194
1 parent c613bdf
commit d3e9194
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/distro.py b/distro.py
@@ -1134,6 +1134,8 @@ def _uname_info(self) -> Dict[str, str]:
 
     @staticmethod
     def _parse_uname_content(lines: Sequence[str]) -> Dict[str, str]:
+        if not lines:
+            return {}
         props = {}
         match = re.search(r"^([^\s]+)\s+([\d\.]+)", lines[0].strip())
         if match:

diff --git a/tests/resources/testdistros/distro/emptyuname/bin/uname b/tests/resources/testdistros/distro/emptyuname/bin/uname
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+echo -n
diff --git a/tests/test_distro.py b/tests/test_distro.py
@@ -716,6 +716,14 @@ def test_bad_uname(self):
         assert self.distro.uname_attr("name") == ""
         assert self.distro.uname_attr("release") == ""
 
+    def test_empty_uname(self):
+        self._setup_for_distro(os.path.join(TESTDISTROS, "distro", "emptyuname"))
+        self.distro = distro.LinuxDistribution()
+
+        assert self.distro.uname_attr("id") == ""
+        assert self.distro.uname_attr("name") == ""
+        assert self.distro.uname_attr("release") == ""
+
     def test_usrlibosreleaseonly(self):
         self._setup_for_distro(
             os.path.join(TESTDISTROS, "distro", "usrlibosreleaseonly")