convergence utility tools #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add documentation on these tools here: |
zingale
approved these changes
Apr 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr makes
convergence.pymore general so that it takes any variable we want with the arbitrary multiplicative factor of resolutions apart between plot files. The default is still density and twice the resolution between the fine plot files and the coarse plot files.convergence_plot.pyallows users to give 3 or more output files which the corresponding resolution differs by a constant multiplicative constant.The goal here is to duplicate the Richardson utility tool that we had in castro/amrex. It outputs the table that tells us the convergence rate as well as a plot.
I think this is different from what Simon had, since Simon had a routine comparing solutions to an analytical solution, whereas here I'm comparing the solution by averaging down a solution with higher resolution.