Skip to content

[WIP] fix the sponge source #336

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jan 26, 2025
Merged

[WIP] fix the sponge source #336

merged 3 commits into from
Jan 26, 2025

Conversation

zingale
Copy link
Collaborator

@zingale zingale commented Jan 26, 2025

I forgot to include the kinetic energy source

I forgot to include the kinetic energy source
@zingale
Copy link
Collaborator Author

zingale commented Jan 26, 2025

Here's the current implementation of the sponge on the `convection problem:

image

and here's with this fix:

image

Notice that the soundspeed in the buffer region is much better behaved now -- we are not heating that region because of the sponge anymore

@zingale
Copy link
Collaborator Author

zingale commented Jan 26, 2025

addresses #335

@zingale
Copy link
Collaborator Author

zingale commented Jan 26, 2025

I see the same level of improvement with the compressible_rk solver

@zingale zingale merged commit 8f5a072 into python-hydro:main Jan 26, 2025
13 checks passed
@zingale zingale deleted the fix_sponge branch January 26, 2025 19:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant