Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vendor mergify schema #487

Closed
hofbi opened this issue Sep 18, 2024 · 4 comments
Closed

Vendor mergify schema #487

hofbi opened this issue Sep 18, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@hofbi
Copy link

hofbi commented Sep 18, 2024

It would be cool that also have mergify available as built in schema and pre defined hook. They provide a their schema in their docs.

This is the config I have for now to make this available without vendoring:

  - repo: https://github.com/python-jsonschema/check-jsonschema
    rev: 0.29.2
    hooks:
      - id: check-jsonschema
        alias: check-mergify
        args: ["--schemafile", "https://docs.mergify.com/mergify-configuration-schema.json"]
        files:
          (?x)^(
            .github/mergify.yml|
            .mergify.yml|
            .mergify/config.yml
          )
        types: [yaml]
@sirosen sirosen added the enhancement New feature or request label Sep 30, 2024
@sirosen
Copy link
Member

sirosen commented Sep 30, 2024

Yep, I'm happy to add this!

I've reached out to Mergify via their contact form to ask if there's a license associated with the schema which I should use. If they don't reply after a week or two -- or reply that there isn't one -- I'll consider it fair game to include. But if there is one, I'll of course include it.

@jd
Copy link

jd commented Sep 30, 2024

👋 @sirosen
I'm from Mergify, and I just got your email 😁
We don't have a license for this; we consider it as being more data and description than code, so it's fine to include it as is.

✌️

sirosen added a commit that referenced this issue Oct 2, 2024
@sirosen sirosen closed this as completed in 286d4be Oct 2, 2024
@sirosen
Copy link
Member

sirosen commented Oct 2, 2024

I've just merged a PR this morning which adds the mergify schema and hook.
I'll have this out in a release probably later today, and I'll update this issue when that's done.

@sirosen
Copy link
Member

sirosen commented Oct 11, 2024

I ended up distracted for ~1 week and didn't push out a release, but I just published v0.29.4 with the Mergify schema and hook! 🎉

Please let me know if you see any issues!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants