Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support workspace symbols #511

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

eyalk11
Copy link

@eyalk11 eyalk11 commented Jan 6, 2024

It simply works. (Telescope lsp_workspace_symbols)

The only comment is that the formatting of document.path and d.module_path was different (don't know why the hell) -
(C:\... vs uri or \...) , so I used the full path for telescope to handle this.

@eyalk11
Copy link
Author

eyalk11 commented Jan 6, 2024

I really suggest to use it with natecraddock/workspaces.nvim#29 . LSP workspace folders is just hell. I improved the commit a bit. but would like to hear from you before investing more time in publishing this.

Just want to make sure the general tendency is to include this after fixes.

@eyalk11 eyalk11 marked this pull request as draft January 6, 2024 21:58
@eyalk11 eyalk11 marked this pull request as ready for review January 7, 2024 23:06
@ccordoba12
Copy link
Member

Hey @eyalk11, thanks for your contribution! I think Jedi provides a better way to extract workspace symbols than doing it file by file, which seems inefficient.

Besides that, your work is also missing tests.

@eyalk11
Copy link
Author

eyalk11 commented Jan 27, 2024

What is the better method? I mean I suppose it doesn't parse all the files by default.

@feakuru
Copy link

feakuru commented May 30, 2024

i'd like to help with this, but i'm reading jedi docs and i can't find any included method to extract workspace symbols, only getting names from a singular script. @ccordoba12 could you clarify what exactly you meant here?

@ccordoba12
Copy link
Member

@feakuru, you can take a look at what jedi-language-server does. If I'm not mistaken, they implemented getting workspace symbols the right way with Jedi.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants