Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unmarshallers format validators refactor #486

Closed

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Jan 25, 2023

Changes:

  • format validators and format unmarshallers split
  • FormatterNotFoundError exception removed. Undefined format raises InvalidSchemaValue with ValidationError instead of FormatterNotFoundError

@p1c2u p1c2u force-pushed the refactor/unmarshallers-format-validators-refactor branch 2 times, most recently from f8d0041 to fbf1bda Compare January 28, 2023 12:52
@p1c2u p1c2u force-pushed the refactor/unmarshallers-format-validators-refactor branch from fbf1bda to 635a1e2 Compare January 28, 2023 13:02
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #486 (635a1e2) into master (c5bb182) will decrease coverage by 0.55%.
The diff coverage is 80.99%.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   91.94%   91.39%   -0.55%     
==========================================
  Files         105      105              
  Lines        2991     3058      +67     
  Branches      266      280      +14     
==========================================
+ Hits         2750     2795      +45     
- Misses        194      205      +11     
- Partials       47       58      +11     
Impacted Files Coverage Δ
openapi_core/validation/request/exceptions.py 82.69% <50.00%> (-1.31%) ⬇️
openapi_core/unmarshalling/schemas/util.py 77.77% <63.63%> (-9.32%) ⬇️
openapi_core/unmarshalling/schemas/exceptions.py 88.46% <71.42%> (-3.85%) ⬇️
openapi_core/unmarshalling/schemas/factories.py 85.48% <73.33%> (-11.89%) ⬇️
openapi_core/unmarshalling/schemas/__init__.py 100.00% <100.00%> (ø)
openapi_core/unmarshalling/schemas/datatypes.py 100.00% <100.00%> (ø)
...penapi_core/unmarshalling/schemas/unmarshallers.py 94.11% <100.00%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@p1c2u
Copy link
Collaborator Author

p1c2u commented Feb 12, 2023

Closing in favor of #508

@p1c2u p1c2u closed this Feb 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant