Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ignore formats for other types in unmarshalling process #599

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Jun 18, 2023

Ignore formats for other types in unmarshalling process. More coverage for the case.

python-openapi/openapi-schema-validator#67

@p1c2u p1c2u force-pushed the fix/xpassed-tests-fix branch 2 times, most recently from 0aebefd to afa33f0 Compare June 22, 2023 18:21
@p1c2u p1c2u force-pushed the fix/xpassed-tests-fix branch from afa33f0 to 2ef7558 Compare August 17, 2023 12:50
@p1c2u
Copy link
Collaborator Author

p1c2u commented Aug 17, 2023

We will have to have follow up breaking change with byte and binary formats returning bytes value.

@p1c2u p1c2u force-pushed the fix/xpassed-tests-fix branch from 3826c02 to a04da78 Compare August 17, 2023 13:20
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #599 (a04da78) into master (bf862ad) will decrease coverage by 0.14%.
Report is 68 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
- Coverage   90.93%   90.79%   -0.14%     
==========================================
  Files         123      123              
  Lines        3452     3532      +80     
  Branches      421      436      +15     
==========================================
+ Hits         3139     3207      +68     
- Misses        263      273      +10     
- Partials       50       52       +2     
Files Changed Coverage Δ
...penapi_core/unmarshalling/schemas/unmarshallers.py 95.65% <100.00%> (+0.04%) ⬆️

... and 9 files with indirect coverage changes

@p1c2u p1c2u merged commit b0042ca into master Aug 17, 2023
@p1c2u p1c2u deleted the fix/xpassed-tests-fix branch August 17, 2023 13:31
@p1c2u p1c2u changed the title Formats raise error for other types fix Ignore formats for other types in unmarshalling process Aug 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant