oxml: don't resolve XML entities in oxml_parser

Resolving entities in the XML is not required by the Open XML standard and represents a security vulnerability. Turn off entity resolution in both the opc (package) parser and the part parser.
python-openxml · Apr 10, 2016 · 61b40b1 · 61b40b1
1 parent 19b1664
commit 61b40b1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/docx/opc/oxml.py b/docx/opc/oxml.py
@@ -16,7 +16,7 @@
 
 # configure XML parser
 element_class_lookup = etree.ElementNamespaceClassLookup()
-oxml_parser = etree.XMLParser(remove_blank_text=True)
+oxml_parser = etree.XMLParser(remove_blank_text=True, resolve_entities=False)
 oxml_parser.set_element_class_lookup(element_class_lookup)
 
 nsmap = {

diff --git a/docx/oxml/__init__.py b/docx/oxml/__init__.py
@@ -14,7 +14,7 @@
 
 # configure XML parser
 element_class_lookup = etree.ElementNamespaceClassLookup()
-oxml_parser = etree.XMLParser(remove_blank_text=True)
+oxml_parser = etree.XMLParser(remove_blank_text=True, resolve_entities=False)
 oxml_parser.set_element_class_lookup(element_class_lookup)