Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve 'download' error message when no sdist #10

Open
thatch opened this issue May 11, 2020 · 3 comments
Open

Improve 'download' error message when no sdist #10

thatch opened this issue May 11, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@thatch
Copy link
Member

thatch commented May 11, 2020

This case is handled properly on 'extract' but not 'download'
@thatch thatch added the good first issue Good for newcomers label May 11, 2020
@thatch
Copy link
Member Author

thatch commented May 11, 2020

Repro: honesty download asn1==2.3.1

@thatch
Copy link
Member Author

thatch commented May 11, 2020

While at it, dedicating an exit status would be good.

thatch added a commit to thatch/honesty that referenced this issue May 13, 2020
@thatch
Sort versions as they come in
71edfed 
This mostly affected the `list` subcommand because `select_version`
already sorts.  Makes sense for us to sanitize the data as soon as
possible.

Since most projects use single digits, it took a while to notice this.

Adds a guard in honesty.api that tries to catch passing in other
objects.  Notably, pkg_resources.parse_version does NOT return
packaging.version.* objects, because they're vendored. :/

Fixes python-packaging#9, python-packaging#10, python-packaging#12
@thatch
Copy link
Member Author

thatch commented May 13, 2020

It's a little better now, but not entirely unified. There are also color differences:

(.venv) [tim@rygel honesty]$ python -m honesty download asn1==2.3.1
Error: asn1==2.3.1 no sdist
(.venv) [tim@rygel honesty]$ python -m honesty extract asn1==2.3.1
Error: asn1 no sdists

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thatch