PCD decoder overruns the shuffle buffer, Fixes #568 #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| # from convert look find on pillow and not imagemagick. | ||
|
|
||
| #target = hopper().resize((768,512)) | ||
| #self.assert_image_similar(im, target, 10) |
There was a problem hiding this comment.
Just curious, why are these lines commented?
There was a problem hiding this comment.
Never mind, I realise again that the comment explains it. This is a potential future test, a kind of todo if you will.
wiredfool
added a commit
that referenced
this pull request
Feb 4, 2016
PCD decoder overruns the shuffle buffer, Fixes #568
bluerise
pushed a commit
to bitrig/bitrig-ports
that referenced
this pull request
Feb 9, 2016
…e.c, where the decoder writes assuming 4 bytes per pixel into a 3 byte per pixel wide buffer, allowing writing 768 bytes off the end of the buffer. This overwrites objects in Python's stack, leading to a crash. python-pillow/Pillow#1706 (There's also a newer upstream release but that will need additional checking before it can go in). Written by: Stuart Henderson <sthen@openbsd.org>
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Feb 17, 2016
fixed buffer overflow in PcdDecode bump PKGREV
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shuffle buffer is initialized to 24bpp, and the pcd decoder offsets 32bpp.