Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added seek 0 and Jpeg for multiframe MPO #3126

Closed
wants to merge 1 commit into from
Closed

Added seek 0 and Jpeg for multiframe MPO #3126

wants to merge 1 commit into from

Conversation

jmetz
Copy link

@jmetz jmetz commented May 9, 2018 •
edited
Loading

Fixes #1631 issue when loading multiple frames of MPO.

Changes proposed in this pull request:

  • Added seek(0) and JpegImagePlugin.JpegImageFile._open(self) after each seek

This works to reinitialise the fp.

@jmetz jmetz mentioned this pull request May 9, 2018
Closed
@hugovk
Copy link
Member

hugovk commented Jul 1, 2018

I've not checked this PR in any detail, but at least the CIs need to pass. Right now TestFileMpo::test_image_grab is failing.

Also new unit tests to verify the fix and protect against regressions.

@radarhere radarhere changed the title Added seek 0 and Jpeg for multiframe MPO fixes #1631 Added seek 0 and Jpeg for multiframe MPO fixes Jan 9, 2019
@radarhere radarhere changed the title Added seek 0 and Jpeg for multiframe MPO fixes Added seek 0 and Jpeg for multiframe MPO Jan 9, 2019
@radarhere radarhere mentioned this pull request Jan 18, 2019
Merged
@radarhere
Copy link
Member

Closing. #3588 replaces this, and is confirmed to be a solution by the author of this PR.

@radarhere radarhere closed this Mar 4, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@radarhere radarhere radarhere left review comments

Assignees
No one assigned
Labels
Needs Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmetz @hugovk @radarhere