Use (void) for empty function parameters

[Yay295]

I just happened to notice that these are the only three C functions that don't take any arguments and use () instead of (void) in their definition.

[Yay295]

Ah, it looks like the webp functions are like that to get rid of the warning. They should actually have two parameters to match the PyMethodDef declaration, but if those parameters were added there would be a warning due to them being unused.

[nulano]

but if those parameters were added there would be a warning due to them being unused.

Can't you just use unnamed parameters to get rid of the warning?

[Yay295]

It looks like the solution in other places is just to cast it to the right type.

[radarhere]

What is the benefit of (void) over ()? It's just a stylistic choice right, to try and more clearly communicate that there are no arguments?

If this is the general agreement, then sure, go ahead - but to me, requiring casting is a step too far for just a style preference.

[Yay295]

Casting is already used for this reason quite a lot elsewhere already. By "other places" I meant "other places in Pillow"; I wasn't talking about other projects.

Pillow/src/_webp.c

Lines 530 to 536 in c250a44

	static struct PyMethodDef _anim_decoder_methods[] = {
	{"get_info", (PyCFunction)_anim_decoder_get_info, METH_NOARGS, "get_info"},
	{"get_chunk", (PyCFunction)_anim_decoder_get_chunk, METH_VARARGS, "get_chunk"},
	{"get_next", (PyCFunction)_anim_decoder_get_next, METH_NOARGS, "get_next"},
	{"reset", (PyCFunction)_anim_decoder_reset, METH_NOARGS, "reset"},
	{NULL, NULL} /* sentinel */
	};

https://github.com/search?q=repo%3Apython-pillow%2FPillow+%28PyCFunction%29&type=code

[radarhere]

Casting is already used for this reason

None of those castings involve functions that have (void) for their parameters.

[Yay295]

The WEBP functions were removed in #8213, so it's just the one JPEG function now.

[radarhere]

What is the benefit of (void) over ()? It's just a stylistic choice right, to try and more clearly communicate that there are no arguments?

[Yay295]

They technically have different meanings in C. func(void) means "this function does not take any arguments", while func() means "this function takes an undefined number of arguments of undefined types". I believe I saw this come up as a warning somewhere when compiling, but I don't remember where, or what flags I might have enabled.