Use common test scripts for more tests #8396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Sep 19, 2024
| - '%PYTHON%\%EXECUTABLE% -m pytest -vx --cov PIL --cov Tests --cov-report term --cov-report xml Tests' | ||
| #- '%PYTHON%\%EXECUTABLE% test-installed.py -v -s %TEST_OPTIONS%' TODO TEST_OPTIONS with pytest? | ||
| - PATH %PYTHON%;%PATH% | ||
| - .ci\test.cmd |
There was a problem hiding this comment.
Hmm. A minor concern perhaps, but your new version uses a hardcoded value for the Python executable, rather than the configuration from earlier in the file.
Line 17 in 629c490
There was a problem hiding this comment.
All of the test environments use a hardcoded executable name, and even in this file %EXECUTABLE% is always python.exe.
radarhere
reviewed
Sep 20, 2024
radarhere
reviewed
Sep 21, 2024
nulano
suggested changes
Sep 22, 2024
Yay295
force-pushed
the
common_test_script
branch
from
08925b3 to
be3192e
Compare
radarhere
approved these changes
Sep 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CI test script for Windows, and update appveyor, mingw, and windows to use the common test scripts.