Make sure filenames containing commas are quoted when writing RECORD file for wheel #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
reviewed
Aug 13, 2020
abn
reviewed
Aug 13, 2020
* use csv.excel constants to define delimiter and quotechar
|
Thanks for your review @abn. I've included your suggestions. |
3 tasks
abn
reviewed
Aug 13, 2020
abn
reviewed
Aug 13, 2020
abn
approved these changes
Aug 14, 2020
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the
csvmodule, to make sure filenames containing commas are quoted, when writing the RECORD file for the wheel packages.Resolves: python-poetry/poetry#2052