Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Breaking change in 1.9.0 following major bump on poetry's dependency constraint? #316

Closed
fhuitelec opened this issue Jan 13, 2025 · 1 comment

Comments

@fhuitelec
Copy link

Hi! 👋

I feel the 1.9.0 release made yesterday (2025/1/12) is introducing a breaking change and should be bumped to a 2.X.X release.

Let me explain: this release introduces #286 which bumped the poetry constraint from >=1.8.0 to >=2.0.0 (cf. pyproject.toml).

To help you understand it from a user point-of-view, I upgraded from 1.8.0 to 1.9.0 without having upgrade poetry to 2.0.1 (I have not yet made the upgrade) and got this error:

Because no versions of poetry-plugin-export match >1.9.0,<2.0.0
 and poetry-plugin-export (1.9.0) depends on poetry (>=2.0.0,<3.0.0), poetry-plugin-export (>=1.9.0,<2.0.0) requires poetry (>=2.0.0,<3.0.0).
So, because poetry-instance depends on both poetry (1.8.2) and poetry-plugin-export (^1.9.0), version solving failed.

Per semver, I think this would constitute a breaking change.

The breaking change "line" is thin since it's a plugin and this is subject to interpretation, so I might be wrong and I would not mind you closed this as a non-issue: I just want to check out with you it's not an oversight 🙂

@finswimmer
Copy link
Member

Hey @fhuitelec,

as you said, the breaking line is thin. Usually a breaking change means the behavior has changed. Here the change leads to the situation, that you can no longer install the plugin, but the behavior of the plugin itself hasn't changed in a breaking way. This is the same, when the support for a certain Python version is dropped.

fin swimmer

@finswimmer finswimmer closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants