Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make use of locked markers in lock file version 2.1 and thereby avoid dependency walk failed #286

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

radoering
Copy link
Member

Resolves: #176
Resolves: #183
Requires: python-poetry/poetry#9427

With python-poetry/poetry#9427 we can fix dependency walk failed once and for all. The dependency walker becomes as simple as iterating over a flat list and doing some simple marker operations. There is no complicated erroneous logic anymore because the resulting markers for each locked package can be read from the lock file.

I adapted all tests so they are run with an old lock file without markers and with a new lock file with markers and added a test (at the end) that raises dependency walk failed for an old lock file and succeeds for a new lock file.

@radoering radoering force-pushed the dependency-walk-failed branch 2 times, most recently from e2cdfad to 7a89609 Compare May 20, 2024 14:31
@edgarrmondragon
Copy link

This does resolve the long-standing issue with urllib3 for us: https://github.com/meltano/sdk/actions/runs/9358298538/job/25759841162.

@jbw-vtl
Copy link

jbw-vtl commented Jun 4, 2024

Very interested, we have been having issues with urllib3 as well

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.7% Duplication on New Code (required ≤ 12%)

See analysis details on SonarCloud

@Alexander-Serov
Copy link

Hey! I'm not sure how this repository works. What would be needed to get this Pull Request going? It would be great to solve the longstanding #183

@radoering radoering force-pushed the dependency-walk-failed branch from 34e9f85 to 42f0f17 Compare October 23, 2024 16:07
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.7% Duplication on New Code (required ≤ 12%)

See analysis details on SonarCloud

@radoering
Copy link
Member Author

What would be needed to get this Pull Request going?

It requires a Poetry release that includes python-poetry/poetry#9427. That will be python-poetry/poetry#9448.

@radoering radoering force-pushed the dependency-walk-failed branch from 42f0f17 to 98ddb57 Compare January 5, 2025 16:10
@radoering radoering marked this pull request as ready for review January 5, 2025 16:13
@radoering radoering requested a review from a team January 5, 2025 16:13
@radoering radoering force-pushed the dependency-walk-failed branch from 98ddb57 to 1a8352e Compare January 5, 2025 16:25
@radoering radoering force-pushed the dependency-walk-failed branch from 1a8352e to e67e454 Compare January 5, 2025 16:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency walk failed with 2 different version of same package Dependency walk failed
5 participants