Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

release: bump version to 1.1.0 #132

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

radoering
Copy link
Member

@radoering radoering commented Oct 1, 2022

Added

  • Add support for exporting constraints.txt files (#128).

Fixed

  • Fix an issue where a relative path passed via -o was not interpreted relative to the current working directory (#130).
  • Fix an issue where the names of extras were not normalized according to PEP 685 (#123).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.0% 8.0% Duplication

Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to block 1.1 on #121 if we can get it finished this weekend.

@dimbleby
Copy link
Contributor

dimbleby commented Oct 1, 2022

... #121 if we can get it finished this weekend

probably depends on whether you're willing to overlook, or rectify, the missing testcase ...

@neersighted
Copy link
Member

probably depends on whether you're willing to overlook, or rectify, the missing testcase ...

The intention is to write the test case, yes. I likely will just implement it myself in a successor as the existing PR is not quite correct and the contributor is stuck on writing tests.

@radoering
Copy link
Member Author

The weekend is over so let's go on. We shouldn't delay poetry 1.2.2 and thereby eventually poetry 1.3.0 because of this. By the way, #121 seems like a simple bugfix that can go in a patch release at any time and should not block this release.

@neersighted
Copy link
Member

Go ahead and do it -- I haven't started on rewriting that PR, though it is still quite trivial to fix, I just need to find time.

Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we should bump our Poetry-core dep to 1.2.x -- otherwise, LGTM.

@radoering
Copy link
Member Author

Looks like we should bump our Poetry-core dep to 1.2.x -- otherwise, LGTM.

IMO that's not necessary because it still works with poetry-core 1.1.x. Bumping poetry-core effectively means bumping poetry to 1.2.1. We'll do a bump after the next release of poetry/poetry-core anyway to fix some typing issues.

@neersighted
Copy link
Member

Fair enough!

@neersighted neersighted merged commit efcfd34 into python-poetry:main Oct 3, 2022
@radoering radoering deleted the release/1.1.0 branch November 24, 2024 12:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants