-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Provide hints when an invalid license id is input #1634
Provide hints when an invalid license id is input #1634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JJJollyjim ,
thanks a lot for this improvement of the user experience. I really like it!
I think it is ok if we integrate it into the master branch. Could your rebase your commit on that branch?
fin swimmer
d80be26
to
e2d2268
Compare
Done, I believe :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
3a0e158
to
7276451
Compare
Anything else I can do on this? |
This message is just a friendly reminder, since this PR seems ready to be included. |
@JJJollyjim may I ask you to add a minor change and push again, so that the checks will run again? Afterwards I will be able to merge it. |
7276451
to
d80be26
Compare
d80be26
to
65e042c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks a lot 👍
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Currently, the
poetry new
/init
license field can be a little opaque to new users -- here is the actual output from my first time using poetry a few hours ago:This PR improves the error message to show a link to the SPDX license list, and in common cases, a best-effort guess at which license ids you might be looking for. For example:
Or, if a common license id is recognised:
I'm not a python dev (as evidenced by the fact I didn't know what a license id was :P), feedback is welcome :)