Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Documentation: Fix build command #1914

Merged
merged 2 commits into from
Jan 18, 2020
Merged

Documentation: Fix build command #1914

merged 2 commits into from
Jan 18, 2020

Conversation

brandonaut
Copy link
Contributor

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Fix casing of the -f flag and try to make it clearer that wheel and sdist are the literal strings to pass to --format.

finswimmer
finswimmer approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving the documentation. This really helps us!

@finswimmer finswimmer merged commit 22f06e5 into python-poetry:master Jan 18, 2020
@brandonaut brandonaut deleted the fix-build-doc branch January 20, 2020 14:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonaut @finswimmer