remove 'm' and 'd' ABI tags for Python 3.8 wheels

[koehlma]

Hey everyone,

as of Python 3.8 the m and d ABI flags became obsolete (see 1 and 2). In fact, if present, they do prevent the installation of wheels. However, poetry seems to add those flags anyway. As a result, I cannot install wheels build with poetry build on the same system they were built on.

This pull request fixes a RuntimeWarning if the flags are not present in the environment and prevents the flags from being added to the ABI tag if the Python version is >= 3.8.

Cheers,
Maximilian

Resolves: python-pendulum/pendulum#456

[kasteph]

Thanks for your first contribution! 🚀

It would be great if you could write a test for this -- one doesn't exist yet but you can put it under tests/masonry/utils.

[nirvana-msu]

I can confirm I faced the exact same issue. Any binary wheel built with Poetry 1.0.5 for Python 3.8 under Windows will have m appended to the tag - which in turn makes the wheel impossible to install as per pypa/pip/issues/6885 & pypa/pip/pull/6874

@sdispater @stephsamson this seems like critical issue, with a very simple fix. Would be great if you find some time to review/merge this PR. Btw even pendulum wheel is broken due to the same issue: sdispater/pendulum/issues/456

[koehlma]

It would be great if you could write a test for this -- one doesn't exist yet but you can put it under tests/masonry/utils.

In principle I could do that, however, I find it a bit hard to get started as I do not know where the env object is coming from and what its general structure is. If someone could write a skeleton and construct a mock env, I will provide a test ASAP. Unfortunately, I currently lack the time to dig deeper into this.

[frostming]

@koehlma I added some review comment.

For testing, you can construct a mocked env with

from poetry.utils.env import MockEnv

env = MockEnv(version_info=(3, 8, 0))

[koehlma]

Here you go. I wrote a test and adapted the MockEnv such that I can overwrite config variables.

[abn]

Changes look great. One comment, a good to have.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.