Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle removal of vcs namespace package dependency gracefully #2239

Merged
merged 4 commits into from
Apr 12, 2020

Conversation

abn
Copy link
Member

@abn abn commented Mar 28, 2020

This change ensures the following:

  1. Uninstall package prior to removal of vcs source.
  2. If <pkg.name>-nsp.pth file exists remove it as a workaround to upstream pip issue.

Resolves: #2238

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@abn abn force-pushed the issues/2238 branch 3 times, most recently from 5a47fdf to 7c0a2dd Compare April 10, 2020 16:54
@abn abn merged commit 370d325 into python-poetry:master Apr 12, 2020
@abn abn deleted the issues/2238 branch April 12, 2020 09:28
@sdispater sdispater mentioned this pull request Jun 5, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip installer breaks environment on vcs namespace package removal
2 participants