Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

lock: allow for no-update refresh of lock files #3034

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

abn
Copy link
Member

@abn abn commented Oct 1, 2020

With the changes to the lock file it is important that users are able to refresh their lock files without updating compatible versions.

Relates-to: #3028

@abn abn added the kind/feature Feature requests/implementations label Oct 1, 2020
@abn abn requested a review from a team October 1, 2020 23:19
@abn abn modified the milestones: 1.1, 1.2 Oct 1, 2020
@abn abn force-pushed the lock/no-update branch 2 times, most recently from 4e95465 to a34ace2 Compare October 1, 2020 23:26
@abn abn changed the base branch from master to 1.1 October 1, 2020 23:42
Copy link
Member

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Nonetheless, we should add some tests to ensure everything is in order.

@abn abn removed this from the 1.2 milestone Oct 1, 2020
@abn
Copy link
Member Author

abn commented Oct 2, 2020

@sdispater added a test case for this as well

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants