-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix requirements.txt export for git dependencies #3089
Conversation
After #2662 was merged, exporting requirements with git dependencies triggers an exception due to accessing the first element of an empty list: ```toml [tool.poetry.dependencies] foo = { git = "ssh://git@github.com/foo/bar.git", rev = "301c6cb9f06ab071da7cb942060c64bdf59cd40a" } ``` This commit adds an empty check to avoid the exception.
Hey @abn, could you please be so kind to have a look? I understand that you were the last one to work on this piece of code. I'm not sure if my fix is any good, and maybe one needs to add a test to prevent this from breaking in the future? Sorry, but I can't help much beyond pointing the problem out due to my present workload... |
@zyv can you try with |
@abn thanks for the quick reaction, but the problem is still present for me in |
@zyv I am unable to reproduce this.
|
@abn It seems to me, that the error occurs if there is a git dependency within the dependency.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
After #2662 was merged, exporting requirements with git dependencies triggers an exception due to accessing the first element of an empty list:
This commit adds an empty check to avoid the exception.
Pull Request Check List
Resolves: moneymeets/python-poetry-buildpack#13