Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Documented the use of the "subdirectory" parameter #5949

Merged
merged 5 commits into from
Aug 2, 2022

Conversation

AKuederle
Copy link
Contributor

Documentation for the subdirectory parameter

I looked through the open Pull Requests regarding this topic (#5811 #5648 #5172) and none of them currently add documentation for the parameters.
This is an attempt to document this option.

Let me know, if there is anything I should change/add.

Resolves: #issue-number-here

  • [ x ] Added tests for changed code. (not required is just docs)
  • [ x ] Updated documentation for changed code. (that's what I did :) )

@Secrus Secrus added the area/docs Documentation issues/improvements label Jul 4, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Deploy preview for website ready!

✅ Preview
https://website-7dkxt31bc-python-poetry.vercel.app

Built with commit 52752e7.
This pull request is being automatically deployed with vercel-action

Secrus
Secrus previously requested changes Jul 15, 2022
docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
AKuederle and others added 2 commits August 1, 2022 12:10
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
@AKuederle
Copy link
Contributor Author

@mkniewallner Thanks for the suggestions!

Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
@mkniewallner mkniewallner dismissed Secrus’s stale review August 2, 2022 19:45

Requested changes have been made

@mkniewallner mkniewallner merged commit 83e6c31 into python-poetry:master Aug 2, 2022
@mkniewallner
Copy link
Member

Thanks for your contribution 🎉

efugier pushed a commit to efugier/poetry that referenced this pull request Aug 4, 2022
* Documented the use of the "subdirectory" parameter

* Moved the subdir documentation up

* Update docs/dependency-specification.md

Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>

* Added @mkniewallner editorial changes

Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>

* Fixed final URL

Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>

Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants