Fix race condition in artifact cache #8517
Merged
+176
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2023
Closed
radoering
force-pushed
the
artifact-cache-race-condition
branch
from
50e520a
to
1e58964
Compare
|
Patiently working for this to be available |
|
It's planned for 1.7 (see #8483). I'll probably start with the preparations for the release after this one has been reviewed and merged. |
…pers.download_file into Downloader class
radoering
force-pushed
the
artifact-cache-race-condition
branch
from
1e58964
to
8e89a8d
Compare
… threads and trying to store it in the same location of the artifact cache
radoering
force-pushed
the
artifact-cache-race-condition
branch
from
8e89a8d
to
bb0a64f
Compare
neersighted
approved these changes
Oct 29, 2023
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #7611
Fixes the race condition identified in #7611 (comment)
The first two commits are refactorings to reduce duplicated code and let the artifact cache handle downloads of archives that will be stored in the artifact cache. The third commit is the actual fix, which uses per-artifact locks.