Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: error when lockfile without metadata entry is encountered #8523

Merged

Conversation

iloveitaly
Copy link
Contributor

Without this, you'll get a cryptic 'metadata' in red when running poetry install. This can occur if a poetry.lock file is empty

Not sure of the best way to write a test for this, point me in the right direction and I'll write a test.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

without this, you'll get a cryptic 'metadata' in red when running `poetry install`

this can occur if a poetry.lock file is empty
@radoering
Copy link
Member

This test should be quite similar.

Please also pay attention to the failing pre-commit pipeline. cf https://python-poetry.org/docs/contributing#local-development

@iloveitaly
Copy link
Contributor Author

added test + fixed linting

@radoering radoering merged commit 3002a04 into python-poetry:master Oct 14, 2023
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants