Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add --sync CLI option to update subcommand #8931

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Add --sync CLI option to update subcommand #8931

merged 8 commits into from
Feb 6, 2024

Conversation

Cypher1
Copy link
Contributor

@Cypher1 Cypher1 commented Feb 1, 2024

Adds --sync to the update subcommand to match install.

radoering
radoering requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Can you update the docs and add a test analogous to

poetry/tests/console/commands/test_install.py

Lines 158 to 169 in 776fcb8

def test_sync_option_is_passed_to_the_installer(
tester: CommandTester, mocker: MockerFixture
) -> None:
"""
The --sync option is passed properly to the installer.
"""
assert isinstance(tester.command, InstallerCommand)
mocker.patch.object(tester.command.installer, "run", return_value=1)
tester.execute("--sync")
assert tester.command.installer._requires_synchronization
, please?

@Cypher1
Copy link
Contributor Author

Cypher1 commented Feb 2, 2024

Sounds good. Will get to it soon. Thx

@Cypher1
Copy link
Contributor Author

Cypher1 commented Feb 5, 2024

pre-commit.ci autofix

@Cypher1 Cypher1 requested a review from radoering February 5, 2024 08:47
radoering
radoering requested changes Feb 5, 2024
View reviewed changes
@Cypher1
Copy link
Contributor Author

Cypher1 commented Feb 5, 2024

pre-commit.ci autofix

@Cypher1 Cypher1 requested a review from radoering February 5, 2024 22:06
@radoering radoering added the impact/docs Contains or requires documentation changes label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Deploy preview for website ready!

✅ Preview
https://website-q09xsf619-python-poetry.vercel.app

Built with commit 80c282e.
This pull request is being automatically deployed with vercel-action

@radoering radoering merged commit f3bb139 into python-poetry:master Feb 6, 2024
35 checks passed
@Cypher1
Copy link
Contributor Author

Cypher1 commented Feb 6, 2024

Thanks!

@Cypher1 Cypher1 deleted the updateSync branch February 6, 2024 21:04
@radoering radoering mentioned this pull request Feb 17, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cypher1 @radoering